bugfixes regarding logging, api and db working; small fixes in all of the cogs; moved all the configurable information to the config.py

cogs/status_rotator.py

@@ -7,55 +7,64 @@ from typing import Optional
 
 logger = logging.getLogger(__name__)
 
+
 class StatusRotator(commands.Cog):
-    def __init__(self, bot):
+    def __init__(self, bot, *, status_file: str = 'data/statuses.json', interval: float = 1.0):
         self.bot = bot
         self.statuses: list[str] = []
         self.current_index = 0
-        self.status_file = 'data/statuses.json'
-        
+        self.status_file = status_file
+        self.rotate_status.change_interval(minutes=interval)
+
     async def cog_load(self):
         await self.load_statuses()
         self.rotate_status.start()
-        logger.info("[StatusRotator] status rotator initialized")
-    
+        logger.info("Status rotator initialized with %d statuses", len(self.statuses))
+
+    async def cog_unload(self):
+        self.rotate_status.cancel()
+
     async def load_statuses(self):
         try:
             with open(self.status_file, 'r', encoding='utf-8') as f:
                 data = json.load(f)
-                self.statuses = data.get('statuses', [])
-
-                logger.info(f"[StatusRotator] loaded {len(self.statuses)} statuses")
-                
+            self.statuses = data.get('statuses', [])
+            logger.info("Loaded %d statuses", len(self.statuses))
         except FileNotFoundError:
-            logger.error(f"[StatusRotator] file {self.status_file} notfound")
+            logger.error("Status file not found: %s", self.status_file)
         except json.JSONDecodeError:
-            logger.error(f"[StatusRotaror] err while parsing JSON")
-    
-    def get_random_status(self) -> str:
-        return random.choice(self.statuses)
-    
-    def get_next_status(self) -> str:
+            logger.error("Failed to parse JSON in: %s", self.status_file)
+
+    def get_next_status(self) -> Optional[str]:
+        if not self.statuses:
+            return None
         status = self.statuses[self.current_index]
         self.current_index = (self.current_index + 1) % len(self.statuses)
         return status
-    
+
+    def get_random_status(self) -> Optional[str]:
+        if not self.statuses:
+            return None
+        return random.choice(self.statuses)
+
     async def update_status(self, status_text: Optional[str] = None):
+        if not self.statuses:
+            logger.warning("No statuses loaded, skipping update")
+            return
+
         if status_text is None:
-            status_text = self.get_random_status()
-        
-        activity = discord.Game(name=status_text)
-        
+            status_text = self.get_next_status()
+
         try:
-            await self.bot.change_presence(activity=activity)
-            logger.debug(f"[StatusRotator] status updated: {status_text}")
+            await self.bot.change_presence(activity=discord.Game(name=status_text))
+            logger.debug("Status updated: %s", status_text)
         except Exception as e:
-            logger.error(f"[StatusRotator] err while updating status: {e}")
-    
+            logger.error("Failed to update status: %s", e)
+
     @tasks.loop(minutes=1.0)
     async def rotate_status(self):
         await self.update_status()
-    
+
     @rotate_status.before_loop
     async def before_rotate_status(self):
         await self.bot.wait_until_ready()